[Mesa-dev] [PATCH] anv: fix segfault in anv_BindImageMemory

[Jason Ekstrand]

It's not a problem on sky lake :-)  For a very convoluted reason but yeah,
we should fix this.  Thanks!

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Nov 22, 2016 at 10:06 PM, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> Since bind image memory started memsetting surfaces, the
> device node can't be NULL, since we lookup device->info.has_llc.
>
> Not sure why it ever was NULL before.
>
> Fixes some things on my Ivybridge.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/intel/vulkan/anv_wsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c
> index c504658..669eacc 100644
> --- a/src/intel/vulkan/anv_wsi.c
> +++ b/src/intel/vulkan/anv_wsi.c
> @@ -200,7 +200,7 @@ x11_anv_wsi_image_create(VkDevice device_h,
>     memory = anv_device_memory_from_handle(memory_h);
>     memory->bo.is_winsys_bo = true;
>
> -   anv_BindImageMemory(VK_NULL_HANDLE, image_h, memory_h, 0);
> +   anv_BindImageMemory(device_h, image_h, memory_h, 0);
>
>     struct anv_surface *surface = &image->color_surface;
>     assert(surface->isl.tiling == ISL_TILING_X);
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161122/36cf836c/attachment.html>