[Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

Ilia Mirkin imirkin at alum.mit.edu
Wed Nov 23 15:39:52 UTC 2016


On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George
<george.kyriazis at intel.com> wrote:
> Thanks Emil,
>
> One thing that I am clear about is: what is the difference between Reviewed-by:, Acked-by:, etc.  It sounds like they do the same thing, however in the documentation they are worded as if they mean different things.

Reviewed-by = I am familiar with this code, and I have carefully
looked over your change and am fairly sure that it will work properly
Acked-by = I glanced at the change and it seems reasonable OR I looked
carefully at the change, but am not overly familiar with the
surrounding code

At least that's how I've been using them.

I believe in linux-kernel convention, Reviewed-by has little
significance beyond documentation, and Acked-by is to note that
maintainer A is OK with maintainer B merging code belonging to
maintainer A's area.

  -ilia


More information about the mesa-dev mailing list