[Mesa-dev] [PATCH] docs: fix minor edits and reviewer suggestions
George Kyriazis
george.kyriazis at intel.com
Wed Nov 23 15:58:23 UTC 2016
---
docs/submittingpatches.html | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 2d18c74..be49a2e 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -41,7 +41,7 @@ components.
<code>git bisect</code>.)
<li>Patches should be properly <a href="#formatting">formatted</a>.
<li>Patches should be sufficiently <a href="#testing">tested</a> before submitting.
-<li>Patches should be submitted to <a href="#mailing">submitted to mesa-dev</a>
+<li>Patches should be <a href="#mailing">submitted to mesa-dev</a>
for <a href="#reviewing">review</a> using <code>git send-email</code>.
</ul>
@@ -104,6 +104,7 @@ that should be documented with:
Reviewed-by: Joe Hacker <jhacker at foo.com>
Acked-by: Joe Hacker <jhacker at foo.com>
</pre>
+<li>Patch series that have some of their parts acked/reviewed by someone, should contain above tags for the parts that have been reviewed in subsequent versions of the patch series (v2/v3/etc.), so that reviewers know which parts have already been reviewed.
<li>In order for your patch to reach the prospective reviewer easier/faster,
use the script scripts/get_reviewer.pl to get a list of individuals and include
them in the CC list.
@@ -334,6 +335,7 @@ be rejected:
<h2 id="gittips">Git tips</h2>
<ul>
+<li>Become familiar with <code>git rebase -i ...</code>, especially reording and fixup patches, since it will help you send subsequent versions of patches.
<li>Test for build breakage between patches e.g last 8 commits.
<pre>
git rebase -i --exec="make -j4" HEAD~8
--
2.10.0.windows.1
More information about the mesa-dev
mailing list