[Mesa-dev] [PATCH 0/5] Random radv patches

Fredrik Höglund fredrik at kde.org
Wed Nov 23 22:04:57 UTC 2016


These are some random patches for radv.  The first adds support for
anisotropic filtering on SI/CIK.  Note that this patch has not been
tested.  Patches 2-4 add support for extensions; two of which are
already supported in practice, and one that's trivial to implement.

One thing I noticed is that vkGetDeviceProcAddr() happily resolves the
entry points even when the extension hasn't been enabled.  It shouldn't
according to the specification, but it's not clear to me if this is the
driver or the loader's responsibility.

There is also a validation warning about an invalid device handle when
vkCmdDrawIndirectCountAMD() and vkCmdDrawIndexedIndirectCountAMD()
are called, but that's a bug in the LUNARG_object_tracker layer.

The final patch changes the device name string to use the marketing
name for the GPU.

For example:

    "AMD RADV POLARIS10"

Becomes:

    "AMD Radeon RX 480 Graphics (RADV POLARIS10)"

This one is more of an RFC, because I don't know if this is the string
format we want to use.

Please review.

Fredrik Höglund (5):
      radv: add support for anisotropic filtering on SI-CI
      radv: add support for VK_KHR_sampler_mirror_clamp_to_edge
      radv: add support for VK_AMD_negative_viewport_height
      radv: add support for VK_AMD_draw_indirect_count
      radv: use the marketing name in the deviceName string

 configure.ac                                    |  2 +-
 src/amd/common/ac_nir_to_llvm.c                 | 31 +++++++
 src/amd/vulkan/radv_cmd_buffer.c                | 94 +++++++++++++++++---
 src/amd/vulkan/radv_device.c                    | 23 +++--
 src/amd/vulkan/radv_radeon_winsys.h             |  2 +-
 .../vulkan/winsys/amdgpu/radv_amdgpu_winsys.c   | 43 +++++----
 6 files changed, 151 insertions(+), 44 deletions(-)



More information about the mesa-dev mailing list