[Mesa-dev] [PATCH] anv/state: if enabled, use anisotropic filtering also with VK_FILTER_NEAREST

[Iago Toral]

Hi Lionel,

On Thu, 2016-11-24 at 13:08 +0000, Lionel Landwerlin wrote:
> Hi Iago,
> 
> Looking at the history, before
> ed4fe3e9ba9018e68afe6fdd4f267218a537fdaa 
> we seem to set min/mag filter to MAPFILTER_ANISOTROPIC if
> maxAnisotropy 
>  > 1. It seems your patch makes sense in using MAPFILTER_ANISOTROPIC
> in 
> the NEAREST case, but I wonder whether we should also check for 
> maxAnisotropy > 1.

Right, good catch, although I think that if we do that it should be a
separate change since we are not currently checking that for the linear
filter either.

It seems that we do check for this in OpenGL so I think we probably
should do that here as well unless Jason dropped it for Vulkan on
purpose for some reason in that commit.

I'll send a separate patch for this after I confirm that it does not
alter the results for the tests in CTS if we add that check.

Iago

> On 24/11/16 11:30, Iago Toral Quiroga wrote:
> > 
> > Fixes multiple Vulkan CTS tests that combine anisotropy and
> > VK_FILTER_NEAREST
> > in dEQP-VK.texture.filtering_anisotropy.*
> > ---
> >   src/intel/vulkan/genX_state.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/intel/vulkan/genX_state.c
> > b/src/intel/vulkan/genX_state.c
> > index 4122395..0f621f9 100644
> > --- a/src/intel/vulkan/genX_state.c
> > +++ b/src/intel/vulkan/genX_state.c
> > @@ -101,7 +101,7 @@ vk_to_gen_tex_filter(VkFilter filter, bool
> > anisotropyEnable)
> >      default:
> >         assert(!"Invalid filter");
> >      case VK_FILTER_NEAREST:
> > -      return MAPFILTER_NEAREST;
> > +      return anisotropyEnable ? MAPFILTER_ANISOTROPIC :
> > MAPFILTER_NEAREST;
> >      case VK_FILTER_LINEAR:
> >         return anisotropyEnable ? MAPFILTER_ANISOTROPIC :
> > MAPFILTER_LINEAR;
> >      }
> 
>