[Mesa-dev] [PATCH] vulkan/wsi: Fix resource leak in success path of wsi_queue_init()

Eduardo Lima Mitev elima at igalia.com
Fri Nov 25 15:49:25 UTC 2016


On 11/25/2016 03:39 PM, Mun Gwan-gyeong wrote:
> It fixes leakage of pthread_condattr resource on wsi_queue_init()
> 

Good catch.

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

> Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
> ---
>  src/vulkan/wsi/wsi_common_queue.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vulkan/wsi/wsi_common_queue.h b/src/vulkan/wsi/wsi_common_queue.h
> index 0e72c8d..6d489cb 100644
> --- a/src/vulkan/wsi/wsi_common_queue.h
> +++ b/src/vulkan/wsi/wsi_common_queue.h
> @@ -65,6 +65,7 @@ wsi_queue_init(struct wsi_queue *queue, int length)
>     if (ret)
>        goto fail_cond;
>  
> +   pthread_condattr_destroy(&condattr);
>     return 0;
>  
>  fail_cond:
> 



More information about the mesa-dev mailing list