[Mesa-dev] [PATCH] anv: enable drawIndirectFirstInstance

Ilia Mirkin imirkin at alum.mit.edu
Sun Nov 27 16:01:23 UTC 2016


On Sun, Nov 27, 2016 at 2:44 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Tuesday, November 22, 2016 11:20:11 PM PST Ilia Mirkin wrote:
>> This was already piped through in the CmdDraw(Indexed)Indirect handling.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>
>> Passes the 2 vk-cts tests dedicated to it as well.
>>
>>  src/intel/vulkan/anv_device.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
>> index 9909107..7cce92c 100644
>> --- a/src/intel/vulkan/anv_device.c
>> +++ b/src/intel/vulkan/anv_device.c
>> @@ -412,7 +412,7 @@ void anv_GetPhysicalDeviceFeatures(
>>        .dualSrcBlend                             = true,
>>        .logicOp                                  = true,
>>        .multiDrawIndirect                        = false,
>> -      .drawIndirectFirstInstance                = false,
>> +      .drawIndirectFirstInstance                = true,
>>        .depthClamp                               = true,
>>        .depthBiasClamp                           = true,
>>        .fillModeNonSolid                         = true,
>>
>
> Yep, this is hooked up.
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks Ken! Do you want to run these through your VK CI, or should I
push? [I don't currently have a branch pointed at the VK CI.]

  -ilia


More information about the mesa-dev mailing list