[Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

[Kyriazis, George]

I'll retract this diff for now, then.

George

> -----Original Message-----
> From: Jose Fonseca [mailto:jfonseca at vmware.com]
> Sent: Thursday, November 24, 2016 1:42 PM
> To: Emil Velikov <emil.l.velikov at gmail.com>; Kyriazis, George
> <george.kyriazis at intel.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>
> Subject: Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and
> GALLIUM_RBUG to gdi
> 
> On 23/11/16 17:37, Emil Velikov wrote:
> > On 23 November 2016 at 16:14, George Kyriazis
> <george.kyriazis at intel.com> wrote:
> >> ---
> >>  src/gallium/targets/libgl-gdi/SConscript  | 1 +
> >> src/gallium/targets/libgl-gdi/libgl_gdi.c | 4 ++++
> >>  2 files changed, 5 insertions(+)
> >>
> >> diff --git a/src/gallium/targets/libgl-gdi/SConscript
> >> b/src/gallium/targets/libgl-gdi/SConscript
> >> index d3251ca..adb3581 100644
> >> --- a/src/gallium/targets/libgl-gdi/SConscript
> >> +++ b/src/gallium/targets/libgl-gdi/SConscript
> >> @@ -41,6 +41,7 @@ if env['gcc'] and env['machine'] != 'x86_64':
> >>  else:
> >>      sources += ['#src/gallium/state_trackers/wgl/opengl32.def']
> >>
> >> +env.Append(CPPDEFINES = ['GALLIUM_TRACE', 'GALLIUM_RBUG'])
> >>  drivers += [trace, rbug]
> >>
> >>  env['no_import_lib'] = 1
> >> diff --git a/src/gallium/targets/libgl-gdi/libgl_gdi.c
> >> b/src/gallium/targets/libgl-gdi/libgl_gdi.c
> >> index 12576db..4b0819f 100644
> >> --- a/src/gallium/targets/libgl-gdi/libgl_gdi.c
> >> +++ b/src/gallium/targets/libgl-gdi/libgl_gdi.c
> >> @@ -55,6 +55,8 @@
> >>  #include "swr/swr_public.h"
> >>  #endif
> >>
> >> +#include "target-helpers/inline_debug_helper.h"
> >> +
> >>  static boolean use_llvmpipe = FALSE;  static boolean use_swr =
> >> FALSE;
> >>
> >> @@ -100,6 +102,8 @@ gdi_screen_create(void)
> >>        screen = softpipe_create_screen( winsys );
> >>     }
> >>
> >> +   screen = debug_screen_wrap(screen);
> >> +
> > Heh, nice one. Considering the nice comment in gdi_sw_display() did
> > you test this on llvmpipe/softpipe ?
> >
> > At the same time, we can simplify a lot of stuff here:
> >  - replace the explicit driver specific winsys retrieval +
> > gdi_sw_display() calls with pipe_screen::flush_frontbuffer() as
> > mentioned in the gdi_sw_display() comment.
> > The pipe_screen callback does effectively the same thing for
> softpipe/llvmpipe.
> >  - drop the use_* variables and use inline_sw_helper.h
> > sw_screen_create() instead of open-coding it.
> >
> > Jose, does this sounds about right ? Did you guys intentionally
> > (considering the comment?) _not_ use the trace/rbug drivers, despite
> > that one links against them ?
> 
> Right.  We'd need some way to traverse the layers (doable but brittle).
> Or move all needed functionality to gallium interfaces, and kill the off-the-
> side communication channel (doable and realible, but complex.)
> 
> Jose