[Mesa-dev] [PATCH v2 4/5] anv: Add missing error-checking to anv_CreateDevice (v2)

[Emil Velikov]

Hi Mun Gwan-gyeong,

There is a minor comment below while the rest of your patches are in master.
Thanks!

On 26 November 2016 at 07:29, Mun Gwan-gyeong <elongbug at gmail.com> wrote:

> @@ -942,7 +968,7 @@ VkResult anv_CreateDevice(
>        unreachable("unhandled gen");
>     }
>     if (result != VK_SUCCESS)
> -      goto fail_fd;
> +      goto fail_workaround_bo;
>
>     anv_device_init_blorp(device);
>
> @@ -952,6 +978,25 @@ VkResult anv_CreateDevice(
>
>     return VK_SUCCESS;
>
> + fail_workaround_bo:
The following two seems to be missing yet I haven't checked if/how
much it matters.

   anv_queue_finish(&device->queue);
   anv_scratch_pool_finish(device, &device->scratch_pool);


-Emil