[Mesa-dev] [PATCH 4/4] i965/sched: Schedule trivial blocks.

[Francisco Jerez]

Matt Turner <mattst88 at gmail.com> writes:

> In commit 45cd76e342d1e8e schedule_instructions(bblock_t *) began
> setting bblock_t::cycle_count, but that function was not called on
> trivial blocks.
>
> Remove the code to skip trivial blocks so that cycle_count is set.
> ---
>  src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> index 9d7ba3b..b3f7e87 100644
> --- a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> @@ -1694,9 +1694,6 @@ instruction_scheduler::run(cfg_t *cfg)
>        setup_liveness(cfg);
>  
>     foreach_block(block, cfg) {
> -      if (block->end_ip - block->start_ip <= 1)
> -         continue;
> -
>        if (reads_remaining) {
>           memset(reads_remaining, 0,
>                  grf_count * sizeof(*reads_remaining));

Looks good, series is:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> -- 
> 2.7.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161128/945c10bb/attachment.sig>