[Mesa-dev] [PATCH 16/18] intel/genxml: Fix ksp for INTERFACE_DESCRIPTOR_DATA

[Jason Ekstrand]

Thanks!  I've been meaning to fix this.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Nov 29, 2016 at 12:48 PM, Kristian H. Kristensen <
hoegsberg at gmail.com> wrote:

> This one was split across two dwords as "Kernel Start Pointer" and
> "Kernel Start Pointer High", which looks like it works when the driver
> only accesses "Kernel Start Pointer". This breaks, of course, with BO
> offsets > 4G.
>
> Signed-off-by: Kristian H. Kristensen <hoegsberg at gmail.com>
> ---
>  src/intel/genxml/gen8.xml | 3 +--
>  src/intel/genxml/gen9.xml | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> index 17234f6..6769077 100644
> --- a/src/intel/genxml/gen8.xml
> +++ b/src/intel/genxml/gen8.xml
> @@ -595,8 +595,7 @@
>    </struct>
>
>    <struct name="INTERFACE_DESCRIPTOR_DATA" length="8">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
> -    <field name="Kernel Start Pointer High" start="32" end="47"
> type="offset"/>
> +    <field name="Kernel Start Pointer" start="6" end="47" type="offset"/>
>      <field name="Denorm Mode" start="83" end="83" type="uint">
>        <value name="Ftz" value="0"/>
>        <value name="SetByKernel" value="1"/>
> diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml
> index c9fb770..3b8ffeb 100644
> --- a/src/intel/genxml/gen9.xml
> +++ b/src/intel/genxml/gen9.xml
> @@ -605,8 +605,7 @@
>    </struct>
>
>    <struct name="INTERFACE_DESCRIPTOR_DATA" length="8">
> -    <field name="Kernel Start Pointer" start="6" end="31" type="offset"/>
> -    <field name="Kernel Start Pointer High" start="32" end="47"
> type="offset"/>
> +    <field name="Kernel Start Pointer" start="6" end="47" type="offset"/>
>      <field name="Denorm Mode" start="83" end="83" type="uint">
>        <value name="Ftz" value="0"/>
>        <value name="SetByKernel" value="1"/>
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161129/60a3deb6/attachment.html>