[Mesa-dev] [PATCH 0/18] Misc genxml patches

Jason Ekstrand jason at jlekstrand.net
Wed Nov 30 00:19:21 UTC 2016


I'm a bit inclined to drop patch 15 because I think tile mode deserves to
remain inline.  I don't care about 17.  I didn't really review it for not
breaking things though.  The rest are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Don't push until you get Jenkins' ok though!

--Jason

On Tue, Nov 29, 2016 at 12:55 PM, Kristian Høgsberg <hoegsberg at gmail.com>
wrote:

> On Tue, Nov 29, 2016 at 12:48 PM Kristian H. Kristensen <
> hoegsberg at gmail.com> wrote:
>
>> Hi,
>>
>> Here's a few patches to the genxml files that I've been sitting on. The
>> main part of the series is about emitting C enums for genxml enums, so
>> it looks nice and pretty in gdb. It also adds support to aubinator so
>> it knows how to decode enums as well as the inline values Lionel added
>> support for:
>>
>>     Surface Array: true
>>     Surface Format: 2 (R32G32B32A32_UINT)
>>     Surface Vertical Alignment: 1 (VALIGN 4)
>>
>> Look at that surface format being decoded! Patch 17 is "take it or
>> leave it". I know nothing in mesa needs unpack functions, but I wouldn't
>> mind having it upstream so I don't lose it (again).
>>
>
> Oh, and true to form, I forgot the most important point: patch 16 is a
> legitimate
> fix for the compute shader KSP being split across a innocuous looking
> KernelStartPointer
> 32 bit field and a 16 bit "Kernel Start Pointer High" field. The driver
> doesn't know this
> and only sets KernelStartPointer. As long as anv uses instruction base
> offset, it's unlikely to
> cause a problem, but should be fixed.
>
> Kristian
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161129/f8e575a9/attachment.html>


More information about the mesa-dev mailing list