[Mesa-dev] [PATCH 23/50] glsl/standalone: Enable ARB_gpu_shader_int64

[Matt Turner]

On 11/28, Ian Romanick wrote:
>From: Ian Romanick <ian.d.romanick at intel.com>
>
>Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>---
> src/compiler/glsl/ir_builder_print_visitor.cpp | 16 +++++++++++++---
> src/compiler/glsl/standalone_scaffolding.cpp   |  1 +
> 2 files changed, 14 insertions(+), 3 deletions(-)
>
>diff --git a/src/compiler/glsl/ir_builder_print_visitor.cpp b/src/compiler/glsl/ir_builder_print_visitor.cpp
>index 91a73c9..a3a5fe4 100644
>--- a/src/compiler/glsl/ir_builder_print_visitor.cpp
>+++ b/src/compiler/glsl/ir_builder_print_visitor.cpp
>@@ -396,13 +396,23 @@ ir_builder_print_visitor::visit(ir_constant *ir)
>
>             memcpy(&v, &ir->value.d[i], sizeof(v));
>             if (v != 0)
>-               /* FIXME: This won't actually work until ARB_gpu_shader_int64
>-                * support lands.
>-                */
>                print_without_indent("r%04X_data.u64[%u] = 0x%016" PRIx64 "; /* %g */\n",
>                                     my_index, i, v, ir->value.d[i]);
>             break;
>          }
>+         case GLSL_TYPE_UINT64:
>+            if (ir->value.u64[i] != 0)
>+               print_without_indent("r%04X_data.u64[%u] = %" PRIu64 ";\n",
>+                                    my_index,
>+                                    i,
>+                                    ir->value.u64[i]);
>+            break;
>+         case GLSL_TYPE_INT64:
>+            if (ir->value.i64[i] != 0)
>+               print_without_indent("r%04X_data.i64[%u] = %" PRId64 ";\n",
>+                                    my_index,
>+                                    i,
>+                                    ir->value.i64[i]);

Missing break. With that fixed,

Reviewed-by: Matt Turner <mattst88 at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161130/5b6ead25/attachment-0001.sig>