[Mesa-dev] [PATCH 8/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_PS

[Jason Ekstrand]

On Sep 30, 2016 3:34 PM, "Anuj Phogat" <anuj.phogat at gmail.com> wrote:
>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/intel/vulkan/gen7_pipeline.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/intel/vulkan/gen7_pipeline.c
b/src/intel/vulkan/gen7_pipeline.c
> index 9411631..4bab0bc 100644
> --- a/src/intel/vulkan/gen7_pipeline.c
> +++ b/src/intel/vulkan/gen7_pipeline.c
> @@ -243,6 +243,10 @@ genX(graphics_pipeline_create)(
>           /* Haswell requires the sample mask to be set in this packet as
well as
>            * in 3DSTATE_SAMPLE_MASK; the values should match. */
>           /* _NEW_BUFFERS, _NEW_MULTISAMPLE */
> +#        if (GEN_IS_HASWELL)

There is some code that uses this #if style but I think the "official"
style is to not indent and not use the parens.

> +         ps.SampleMask                    = 0xff;
> +#        endif
> +         ps.SamplerCount                  = 1;

Of we're going to add code to set sampler count, it should be accurate.
It's probably best to drop this line and have a later patch which actually
sets it correctly.

>        }
>
>        uint32_t samples = pCreateInfo->pMultisampleState ?
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160930/b21bffc1/attachment.html>