[Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

[Tobias Droste]

I was looking at a per driver check for vulkan, but then this can't reuse the 
existing functions to check llvm version.

The LLVM version checks are also the reason this is done is such a weird way 
for gallium. It doesn't make sense there too and should be per driver too.

This patch was just the way of the least resistance by reusing as much as 
possible and make it actually work. 
If you have something better, I don't mind if you ignore this :-)

Tobias

Am Dienstag, 4. Oktober 2016, 10:25:38 CEST schrieb Dave Airlie:
> On 3 October 2016 at 05:45, Tobias Droste <tdroste at gmx.de> wrote:
> > This reuse the same logic gallium uses to determine if LLVM is needed or
> > not:
> > --enable-vulkan-llvm is set to yes if at least one vulkan driver is
> > active and the host is i3*6 or x86_64.
> > To build vulkan drivers without LLVM (e.g. intel) one has to add
> > --disable-vulkan-llvm.
> > 
> > In order to make this all work the vulkan driver check has to move
> > either diretcly below or directly above the gallium driver checks.
> > Move them below the gallium driver stuff.
> 
> I don't think basing this on gallium is correct, as gallium is used across
> dirvers, the vulkan drivers are pretty separate at this point, so it should
> just be a per driver check for llvm, not a vulkan level one.
> 
> I'll try and clean things up today in there before proposing for master.
> 
> Dave.


-- 
Mit freundlichen Grüßen
Tobias Droste