[Mesa-dev] radv initial submission

Nicolai Hähnle nhaehnle at gmail.com
Tue Oct 4 11:03:56 UTC 2016

On 04.10.2016 03:48, Dave Airlie wrote:
> Hi all,
> I fully expect this won't make it to the list in one piece due to size.
> I've pushed the same patchset to
> https://github.com/airlied/mesa/tree/radv-submit

Even Github refuses to render the diff of patch #3 for me, but I skimmed 
over it using proper tools ;-)

Some things I noticed:

- radv_device_info.h has no copyright header
- radv_timestamp.h shouldn't be in Git
- Makefile.am still refers to GEN7_FILES
- lots of odd-looking alignment and whitespace at end-of-lines; please 
at least fix the whitespace at EOL before pushing, since that tends to 
create annoying churn

I've also sent comments on the other patches. I'd say this is fairly 
close to mergeable as far as I'm concerned. Congratulations on your 
effort! :)


> This is an initial submission of the open source radv vulkan driver
> for AMD GPUs supported by the amdgpu driver. It is a project Bas and I
> started some months ago as an interesting learning experience and it's
> been great to see it get this far in such a short time.
> This driver is in no way to be considered conformant or called such.
> It has NOT passed the vulkan conformance suite or ever been submitted
> to Khronos. It prints a big warning on startup to this effect.
> In saying that, it runs quite well with Dota 2, Talos Principle and
> vkQuake in our testing so far.
> Future plans are to add support for various hw speedups (fast clears),
> missing things like spilling, and multiple queues along with finishing
> out things like geom/tess shaders. Also trying to reuse code between
> this and the radeonsi driver where possible. radv already reuses
> the LLVM compiler backend and the addrlib code.
> I've split things out into 4 patches, 3 just add code files to various
> places and number 4 intergrates the build system changes so they
> are easier to review.
> Regards,
> Dave (and on behalf of Bas).
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

More information about the mesa-dev mailing list