[Mesa-dev] [PATCH] i965/l3: Remove redundant is_cherryview check

Anuj Phogat anuj.phogat at gmail.com
Tue Oct 4 20:42:59 UTC 2016


On Tue, Oct 4, 2016 at 1:30 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> All mobile parts (so far) are GT1. The check added extra confusion
> because it appeared Broxton was missing when it wasn't. Replace it with
> a comment.
>
> Alternatively, I'd be willing to add an is_broxton check.
>
> Cc: Francisco Jerez <currojerez at riseup.net>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> ---
>  src/intel/common/gen_l3_config.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/common/gen_l3_config.c b/src/intel/common/gen_l3_config.c
> index b172ef6..eb4e8ae 100644
> --- a/src/intel/common/gen_l3_config.c
> +++ b/src/intel/common/gen_l3_config.c
> @@ -258,7 +258,8 @@ get_l3_way_size(const struct gen_device_info *devinfo)
>     if (devinfo->is_baytrail)
>        return 2;
>
> -   else if (devinfo->is_cherryview || devinfo->gt == 1)
> +   /* XXX: Cherryview and Broxton are always gt1 */
> +   else if (devinfo->gt == 1)
>        return 4;
>
>     else
> --
> 2.10.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the mesa-dev mailing list