[Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

[Axel Davy]

Hi,

as of writing, there doesn't seem to be a concensus on the fix.
Could one be found for Mesa 13 ? Gallium nine is apparently broken
except on radeonsi which zeros out the next field... It'd need either the
proposed patch of this thread merged, or to zero the next field everywhere.

I guess other state trackers need to be fixed as well before the release.

Axel

On 04/10/2016 02:13, Roland Scheidegger wrote:
> The reason I don't like this isn't really the number of callers, rather
> that the driver is going actively against what the state tracker told it
> to do. But I'm not strongly opposed to this, since effectively
> restricting the next field to be only valid if the resource is created
> externally might be a good idea on its own...
> Albeit zero-initializing in the state tracker has the advantage that if
> resource struct is going to be extended again it would work too.
> (Technically, there's no need that the template and the actual resource
> struct being the same it just makes things easier - with d3d10 in the
> driver interface you basically only have the templates since the drivers
> just return pointers to void.)
>
> Roland
>
> Am 04.10.2016 um 01:55 schrieb Marek Olšák:
>> BTW, I think fixing this in drivers is better, because the number of
>> resource_create implementations is limited and they are easy to find.
>>
>> Marek
>>
>> On Tue, Oct 4, 2016 at 1:45 AM, Roland Scheidegger <sroland at vmware.com> wrote:
>>> Sounds reasonable to me.
>>>
>>> Roland
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=CwIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=yZpTz6pGgFoZbK1LUVEwWTMRb1aA9Mib1imtI8mWHaM&s=hBrxe77phVUzt8iueqi-kYpf4UxiX1-K_uXhtnGSy04&e=
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev