[Mesa-dev] [PATCH] util: remove unused variable

Nicolai Hähnle nhaehnle at gmail.com
Fri Oct 7 10:12:29 UTC 2016


On 07.10.2016 12:10, Timothy Arceri wrote:
> Also initialise page at declaration.
>
> Cc: Nicolai Hähnle <nicolai.haehnle at amd.com>

Thanks!

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

> ---
>  src/util/slab.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/util/slab.c b/src/util/slab.c
> index cbe4c88..4264814 100644
> --- a/src/util/slab.c
> +++ b/src/util/slab.c
> @@ -174,11 +174,9 @@ void slab_destroy_child(struct slab_child_pool *pool)
>  static bool
>  slab_add_new_page(struct slab_child_pool *pool)
>  {
> -   struct slab_page_header *page;
> -   unsigned i;
> +   struct slab_page_header *page = malloc(sizeof(struct slab_page_header) +
> +      pool->parent->num_elements * pool->parent->element_size);
>
> -   page = malloc(sizeof(struct slab_page_header) +
> -                 pool->parent->num_elements * pool->parent->element_size);
>     if (!page)
>        return false;
>
>


More information about the mesa-dev mailing list