[Mesa-dev] [PATCH] glsl: Add missing cache_destroy stub function.

[Timothy Arceri]

On Sat, 2016-10-08 at 14:42 +1100, Timothy Arceri wrote:
> Hi Vinson,
> 
> This seems reasonable.
> 
> Although the problem should already be fixed by f546b41f6ac9b4394
> 
> Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
> 
> Thinking about it some more these are probably not used anywhere
> anymore. Carl's used these in the original patch set I believe I've
> updated everything to be wrapped in #ifdef ENABLE_SHADER_CACHE

Although we probably still use the stub cache_create(). Anyway feel
free to push your patch.

> 
> On Fri, 2016-10-07 at 21:00 +0000, Vinson Lee wrote:
> > 
> >   CC       glsl/tests/cache_test.o
> > glsl/tests/cache_test.c: In function ‘test_cache_create’:
> > glsl/tests/cache_test.c:160:4: error: implicit declaration of
> > function ‘cache_destroy’ [-Werror=implicit-function-declaration]
> >     cache_destroy(cache);
> >     ^
> > 
> > Fixes: 87ab26b2ab35 ("glsl: Add initial functions to implement an
> > on-
> > disk cache")
> > Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> > ---
> >  src/compiler/glsl/cache.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/compiler/glsl/cache.h b/src/compiler/glsl/cache.h
> > index 78df32b6c54e..d804169c6561 100644
> > --- a/src/compiler/glsl/cache.h
> > +++ b/src/compiler/glsl/cache.h
> > @@ -139,6 +139,11 @@ cache_create(void)
> >  }
> >  
> >  static inline void
> > +cache_destroy(struct program_cache *cache) {
> > +   return;
> > +}
> > +
> > +static inline void
> >  cache_put(struct program_cache *cache, cache_key key,
> >            const void *data, size_t size)
> >  {
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev