[Mesa-dev] [PATCH 2/2] i965: Fix typo in nir_op_pack_double_2x32_split handling

[Eduardo Lima Mitev]

On 10/08/2016 02:12 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> This was found partially by inspection and partially by hitting a
> problem while working on nir_op_pack_int64_2x32_split.  The code
> previously would 'continue' if (instr->src[i].src.is_ssa), but the code
> immediately following in the loop treats instr->src[i] as an SSA value.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Iago Toral Quiroga <itoral at igalia.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 4e68ffb..2cbcab1 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -1208,7 +1208,7 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr)
>         * the unpack operation.
>         */
>        for (int i = 0; i < 2; i++) {
> -         if (instr->src[i].src.is_ssa)
> +         if (!instr->src[i].src.is_ssa)
>              continue;
>  

Good catch!

Both patches are:

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

>           const nir_instr *parent_instr = instr->src[i].src.ssa->parent_instr;
>