[Mesa-dev] [PATCH 06/32] genxml: Add a uint MOCS field to DEPTH_BUFFER packets

Lionel Landwerlin lionel.g.landwerlin at intel.com
Mon Oct 10 08:52:44 UTC 2016


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 11/08/16 22:15, Jason Ekstrand wrote:
> This is easier than dealing with structs all the time
> ---
>   src/intel/genxml/gen6.xml  | 2 ++
>   src/intel/genxml/gen7.xml  | 2 ++
>   src/intel/genxml/gen75.xml | 2 ++
>   src/intel/genxml/gen8.xml  | 2 ++
>   src/intel/genxml/gen9.xml  | 2 ++
>   5 files changed, 10 insertions(+)
>
> diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
> index 06b441b..3fe7377 100644
> --- a/src/intel/genxml/gen6.xml
> +++ b/src/intel/genxml/gen6.xml
> @@ -958,6 +958,7 @@
>       <field name="Depth Coordinate Offset Y" start="176" end="191" type="int"/>
>       <field name="Depth Coordinate Offset X" start="160" end="175" type="int"/>
>       <field name="Depth Buffer Object Control State" start="219" end="223" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Depth Buffer MOCS" start="219" end="223" type="uint"/>
>     </instruction>
>   
>     <instruction name="3DSTATE_DRAWING_RECTANGLE" bias="2" length="4">
> @@ -1038,6 +1039,7 @@
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="15"/>
>       <field name="DWord Length" start="0" end="7" type="uint" default="1"/>
>       <field name="Hierarchical Depth Buffer Object Control State" start="57" end="60" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Hierarchical Depth Buffer MOCS" start="57" end="60" type="uint"/>
>       <field name="Surface Pitch" start="32" end="48" type="uint"/>
>       <field name="Surface Base Address" start="64" end="95" type="address"/>
>     </instruction>
> diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
> index 5e82fab..7e34fd6 100644
> --- a/src/intel/genxml/gen7.xml
> +++ b/src/intel/genxml/gen7.xml
> @@ -1068,6 +1068,7 @@
>       </field>
>       <field name="Minimum Array Element" start="138" end="148" type="uint"/>
>       <field name="Depth Buffer Object Control State" start="128" end="131" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Depth Buffer MOCS" start="128" end="131" type="uint"/>
>       <field name="Depth Coordinate Offset Y" start="176" end="191" type="int"/>
>       <field name="Depth Coordinate Offset X" start="160" end="175" type="int"/>
>       <field name="Render Target View Extent" start="213" end="223" type="uint"/>
> @@ -1198,6 +1199,7 @@
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="7"/>
>       <field name="DWord Length" start="0" end="7" type="uint" default="1"/>
>       <field name="Hierarchical Depth Buffer Object Control State" start="57" end="60" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Hierarchical Depth Buffer MOCS" start="57" end="60" type="uint"/>
>       <field name="Surface Pitch" start="32" end="48" type="uint"/>
>       <field name="Surface Base Address" start="64" end="95" type="address"/>
>     </instruction>
> diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
> index f1be2f84..f0ad177 100644
> --- a/src/intel/genxml/gen75.xml
> +++ b/src/intel/genxml/gen75.xml
> @@ -1177,6 +1177,7 @@
>       </field>
>       <field name="Minimum Array Element" start="138" end="148" type="uint"/>
>       <field name="Depth Buffer Object Control State" start="128" end="131" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Depth Buffer MOCS" start="128" end="131" type="uint"/>
>       <field name="Depth Coordinate Offset Y" start="176" end="191" type="int"/>
>       <field name="Depth Coordinate Offset X" start="160" end="175" type="int"/>
>       <field name="Render Target View Extent" start="213" end="223" type="uint"/>
> @@ -1410,6 +1411,7 @@
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="7"/>
>       <field name="DWord Length" start="0" end="7" type="uint" default="1"/>
>       <field name="Hierarchical Depth Buffer Object Control State" start="57" end="60" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Hierarchical Depth Buffer MOCS" start="57" end="60" type="uint"/>
>       <field name="Surface Pitch" start="32" end="48" type="uint"/>
>       <field name="Surface Base Address" start="64" end="95" type="address"/>
>     </instruction>
> diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml
> index 8145ddd..4ed23db 100644
> --- a/src/intel/genxml/gen8.xml
> +++ b/src/intel/genxml/gen8.xml
> @@ -1216,6 +1216,7 @@
>       <field name="Depth" start="181" end="191" type="uint"/>
>       <field name="Minimum Array Element" start="170" end="180" type="uint"/>
>       <field name="Depth Buffer Object Control State" start="160" end="166" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Depth Buffer MOCS" start="160" end="166" type="uint"/>
>       <field name="Render Target View Extent" start="245" end="255" type="uint"/>
>       <field name="Surface QPitch" start="224" end="238" type="uint"/>
>     </instruction>
> @@ -1452,6 +1453,7 @@
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="7"/>
>       <field name="DWord Length" start="0" end="7" type="uint" default="3"/>
>       <field name="Hierarchical Depth Buffer Object Control State" start="57" end="63" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Hierarchical Depth Buffer MOCS" start="57" end="63" type="uint"/>
>       <field name="Surface Pitch" start="32" end="48" type="uint"/>
>       <field name="Surface Base Address" start="64" end="127" type="address"/>
>       <field name="Surface QPitch" start="128" end="142" type="uint"/>
> diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml
> index 1838d2c..9361edf 100644
> --- a/src/intel/genxml/gen9.xml
> +++ b/src/intel/genxml/gen9.xml
> @@ -1266,6 +1266,7 @@
>       <field name="Depth" start="181" end="191" type="uint"/>
>       <field name="Minimum Array Element" start="170" end="180" type="uint"/>
>       <field name="Depth Buffer Object Control State" start="160" end="166" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Depth Buffer MOCS" start="160" end="166" type="uint"/>
>       <field name="Tiled Resource Mode" start="222" end="223" type="uint">
>         <value name="NONE" value="0"/>
>         <value name="TILEYF" value="1"/>
> @@ -1555,6 +1556,7 @@
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="7"/>
>       <field name="DWord Length" start="0" end="7" type="uint" default="3"/>
>       <field name="Hierarchical Depth Buffer Object Control State" start="57" end="63" type="MEMORY_OBJECT_CONTROL_STATE"/>
> +    <field name="Hierarchical Depth Buffer MOCS" start="57" end="63" type="uint"/>
>       <field name="Surface Pitch" start="32" end="48" type="uint"/>
>       <field name="Surface Base Address" start="64" end="127" type="address"/>
>       <field name="Surface QPitch" start="128" end="142" type="uint"/>




More information about the mesa-dev mailing list