[Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

Emil Velikov emil.l.velikov at gmail.com
Mon Oct 10 11:04:10 UTC 2016


Hi Mauro,

On 9 October 2016 at 11:13, Mauro Rossi <issor.oruam at gmail.com> wrote:

> New generated headers were introduced by commit 63a366a
> "intel: aubinator: generate a standalone binary"
>
> Once the generated files are listed in Makefile.sources variables,
> Android build system requires rules to avoid building error.
>
> New macro xml-header-gen is basically a copy&paste of automake rules,
> but xxd is invoked directly, as Android build systems stops and shows the error
> in case of xxd missing.
>
> Existing macro header-gen is renamed to pack-header-gen as a refinement.
> ---
>  src/intel/Android.genxml.mk | 42 +++++++++++++++++++++++++++++++++---------
>  1 file changed, 33 insertions(+), 9 deletions(-)
>
I second Jason here - the headers are not (and likely won't be anytime
soon) applicable for Android.

The simple fix would be to split the headers introduced with above
commit to a separate list in the Makefile.sources file and append that
one to the BUILT_SOURCES list in src/intel/Makefile.genxml.am. Please
give that a try.

Thanks
Emil


More information about the mesa-dev mailing list