[Mesa-dev] [PATCH mesa] egl: add eglSwapBuffersWithDamageKHR

[Emil Velikov]

On 10 October 2016 at 15:37, Eric Engestrom <eric.engestrom at imgtec.com> wrote:

>> > +static EGLBoolean EGLAPIENTRY
>> > +eglSwapBuffersWithDamageKHR(EGLDisplay dpy, EGLSurface surface,
>> > +                            EGLint *rects, EGLint n_rects)
>> > +{
>> > +   return eglSwapBuffersWithDamageEXT(dpy, surface,
>> > +                                      rects, n_rects);
>> > +}
>> > +
>> Can you respin this on top of the EGL_KHR_debug extension support ?
>
> I just rebased and re-generated the patch, and aside from line numbers
> nothing changed, and it compiles fine.
> Did you have something specific in mind? Is there something I need to
> add/change wrt KHR_debug?
>
> I do have one change to `_eglCreateExtensionsString()` though, so there
> will be a v2, don't pull my patch in just yet :)
>
As-is the debug message will reference the EXT function even if we use
the KHR API (props to the _EGL_FUNC_START macro).
IMHO we want to avoid that if possible but if others feel that we can
get away here so be it. Otherwise we want something like:

Rename the current eglSwapBuffersWithDamageEXT to ...Common, moving
the dpy locking, surface lookup and _EGL_FUNC_START to the KHR/EXT
functions. See eglWaitSync/eglWaitSyncKHR for example (barring
s/sync/surface/).

Thanks
Emil