[Mesa-dev] [PATCH 1/5] anv/cmd_buffer: Clarify HZ rectangle behavior

[Nanley Chery]

This behavior differs from what's described in the PRMs and was
observed by analyzing CTS test results.

Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
---
 src/intel/vulkan/gen8_cmd_buffer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/gen8_cmd_buffer.c
index e6a3c3d..02c2d7c 100644
--- a/src/intel/vulkan/gen8_cmd_buffer.c
+++ b/src/intel/vulkan/gen8_cmd_buffer.c
@@ -558,9 +558,10 @@ genX(cmd_buffer_emit_hz_op)(struct anv_cmd_buffer *cmd_buffer,
          hzp.ClearRectangleXMax = align_u32(iview->extent.width, 8);
          hzp.ClearRectangleYMax = align_u32(iview->extent.height, 4);
       } else {
-         /* This clear rectangle is aligned */
+         /* Contrary to the HW docs both fields are inclusive */
          hzp.ClearRectangleXMin = cmd_state->render_area.offset.x;
          hzp.ClearRectangleYMin = cmd_state->render_area.offset.y;
+         /* Contrary to the HW docs both fields are exclusive */
          hzp.ClearRectangleXMax = cmd_state->render_area.offset.x +
             align_u32(cmd_state->render_area.extent.width, px_dim.width);
          hzp.ClearRectangleYMax = cmd_state->render_area.offset.y +
-- 
2.10.0