[Mesa-dev] [PATCH v2 00/13] st/mesa: finally finish ARB_enhanced_layouts

[Dave Airlie]

On 10 October 2016 at 18:32, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> Hi all,
>
> I've incorporated the minor comments I've received so far and fixed a
> regression related to structs that I had missed. Luckily the fix is pretty
> simple, because struct members cannot have explicit components. So it's
> enough to force their usage mask to XYZW, which means they will be treated
> the same as before. Please review!

Apart from the suggestion I made, I think these all make sense, the glsl->tgsi
code was never greatly understood especially the writemasking stuff was always
 a bit tricky, but if this doesn't make anything worse in that area,
then lets go for it.

Reviewed-by: Dave Airlie <airlied at redhat.com> for all of it.

>
> Thanks
> Nicolai
> --
>  docs/features.txt                            |  18 +-
>  docs/relnotes/12.1.0.html                    |   2 +-
>  src/compiler/glsl/ir_print_visitor.cpp       |  10 +-
>  src/gallium/auxiliary/tgsi/tgsi_scan.c       |   9 +-
>  src/gallium/auxiliary/tgsi/tgsi_ureg.c       | 115 +++-
>  src/gallium/auxiliary/tgsi/tgsi_ureg.h       |  30 ++
>  src/gallium/docs/source/screen.rst           |   8 +
>  .../drivers/freedreno/freedreno_screen.c     |   1 +
>  src/gallium/drivers/i915/i915_screen.c       |   1 +
>  src/gallium/drivers/ilo/ilo_screen.c         |   1 +
>  src/gallium/drivers/llvmpipe/lp_screen.c     |   1 +
>  .../drivers/nouveau/nv30/nv30_screen.c       |   1 +
>  .../drivers/nouveau/nv50/nv50_screen.c       |   1 +
>  .../drivers/nouveau/nvc0/nvc0_screen.c       |   1 +
>  src/gallium/drivers/r300/r300_screen.c       |   1 +
>  src/gallium/drivers/r600/r600_pipe.c         |   1 +
>  src/gallium/drivers/radeonsi/si_pipe.c       |   3 +-
>  src/gallium/drivers/softpipe/sp_screen.c     |   1 +
>  src/gallium/drivers/svga/svga_screen.c       |   1 +
>  src/gallium/drivers/swr/swr_screen.cpp       |   1 +
>  src/gallium/drivers/vc4/vc4_screen.c         |   1 +
>  src/gallium/drivers/virgl/virgl_screen.c     |   1 +
>  src/gallium/include/pipe/p_defines.h         |   1 +
>  src/mesa/state_tracker/st_extensions.c       |   7 +
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp   | 465 ++++++++++-------
>  25 files changed, 432 insertions(+), 250 deletions(-)
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev