[Mesa-dev] [PATCH v2 045/103] i965: move the group field from fs_inst to backend_instruction.
Iago Toral Quiroga
itoral at igalia.com
Tue Oct 11 09:01:49 UTC 2016
Just like the exec_size, we are going to need this in the vec4 backend
when we implement a simd splitting pass.
---
src/mesa/drivers/dri/i965/brw_ir_fs.h | 9 ---------
src/mesa/drivers/dri/i965/brw_shader.h | 9 +++++++++
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 +
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h b/src/mesa/drivers/dri/i965/brw_ir_fs.h
index c569bd4..cad3712 100644
--- a/src/mesa/drivers/dri/i965/brw_ir_fs.h
+++ b/src/mesa/drivers/dri/i965/brw_ir_fs.h
@@ -367,15 +367,6 @@ public:
uint8_t sources; /**< Number of fs_reg sources. */
- /**
- * Channel group from the hardware execution and predication mask that
- * should be applied to the instruction. The subset of channel enable
- * signals (calculated from the EU control flow and predication state)
- * given by [group, group + exec_size) will be used to mask GRF writes and
- * any other side effects of the instruction.
- */
- uint8_t group;
-
bool eot:1;
bool pi_noperspective:1; /**< Pixel interpolator noperspective flag */
};
diff --git a/src/mesa/drivers/dri/i965/brw_shader.h b/src/mesa/drivers/dri/i965/brw_shader.h
index aca26dc..0c8f296 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.h
+++ b/src/mesa/drivers/dri/i965/brw_shader.h
@@ -140,6 +140,15 @@ struct backend_instruction {
*/
uint8_t exec_size;
+ /**
+ * Channel group from the hardware execution and predication mask that
+ * should be applied to the instruction. The subset of channel enable
+ * signals (calculated from the EU control flow and predication state)
+ * given by [group, group + exec_size) will be used to mask GRF writes and
+ * any other side effects of the instruction.
+ */
+ uint8_t group;
+
uint32_t offset; /**< spill/unspill offset or texture offset bitfield */
uint8_t mlen; /**< SEND message length */
int8_t base_mrf; /**< First MRF in the SEND message, if mlen is nonzero. */
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
index 4e7515c..75c60a0 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
@@ -55,6 +55,7 @@ vec4_instruction::vec4_instruction(enum opcode opcode, const dst_reg &dst,
this->base_mrf = 0;
this->offset = 0;
this->exec_size = 8;
+ this->group = 0;
this->size_written = (dst.file == BAD_FILE ?
0 : this->exec_size * type_sz(dst.type));
this->annotation = NULL;
--
2.7.4
More information about the mesa-dev
mailing list