[Mesa-dev] [PATCH v2 1/6] configure.ac: Move LLVM related stuff to the top
emil.l.velikov at gmail.com
Tue Oct 11 14:51:30 UTC 2016
On 11 October 2016 at 15:27, Tobias Droste <tdroste at gmx.de> wrote:
> Hi Emil,
> there's no way I can think of moving only without breaking the build for the
> following reason:
> The llvm check itself depends on several global variables defined later and
> checks stuff it shouldn't do.
> The moved code uses $enable_opencl and $CLANG_LIBDIR and additionally this
> code fails if LLVM is not installed, but at this point in time I don't know if
> I need LLVM!
> In order to do the later patches this stuff has to be at the top.
> I have to either move&change in one go or do nothing.
> That's why originally this was one patch and for this series I said it should
> be squashed when pushed.
> I could (but rather choose not to) split this up with duplicate code and only
> one of them enabled (so not move, but copy code) until the other works.
> But this makes the already fragile configure.ac more fragile inbetween the
> I really wish I could split this up more, but I would rather not.
> Could we just squash patch 1-5 after the other issues you raised are resolved
> and push it as just 2 patches?
My comment in 1/6 explains how you can do things (unless I've lost the
plot) and get things working in that patch. I'm pretty sure you can do
the same for the rest (it's not rocket science after all), you just
need to think a bit harder.
More information about the mesa-dev