[Mesa-dev] [PATCH] radv/winsys: Fix mem leak at failed do_winsys_init() call site

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 11 14:57:34 UTC 2016


On 11 October 2016 at 12:43, Edward O'Callaghan
<funfunctor at folklore1984.net> wrote:
> Probably unlikely however ensure we don't leak a heap allocation
> on the fail path.
>
> V.2:
>  also fix missing 'amdgpu_device_deinitialize()' calls (Emil Velikov).
>
Much better, thanks !

You might want to update the the commit message to reflect reality
"fix leaks in radv_amdgpu_winsys_create() error path" or alike. But
either way the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil
P.S. git format-patch -v2 ... is your friend ;-)


More information about the mesa-dev mailing list