[Mesa-dev] [PATCH 01/12] isl/gen6: correctly check msaa layout samples count

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 11 17:26:15 UTC 2016


From: Emil Velikov <emil.velikov at collabora.com>

Samples == 1 is a valid value, so returning false is plain wrong.
Seeming copy/paste typo introduced since day 1.

Fixes: afdadec77f5 ("isl: Implement isl_surf_init() for gen4-gen9")
Cc: Chad Versace <chadversary at chromium.org>
Cc: Jason Ekstrand <jason.ekstrand at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 src/intel/isl/isl_gen6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/isl/isl_gen6.c b/src/intel/isl/isl_gen6.c
index b30998d..07c08f6 100644
--- a/src/intel/isl/isl_gen6.c
+++ b/src/intel/isl/isl_gen6.c
@@ -35,7 +35,7 @@ gen6_choose_msaa_layout(const struct isl_device *dev,
 
    if (info->samples == 1) {
       *msaa_layout = ISL_MSAA_LAYOUT_NONE;
-      return false;
+      return true;
    }
 
    if (!isl_format_supports_multisampling(dev->info, info->format))
-- 
2.10.0



More information about the mesa-dev mailing list