[Mesa-dev] [PATCH] draw: initialize shader inputs

Kenneth Graunke kenneth at whitecape.org
Wed Oct 12 00:21:55 UTC 2016


On Wednesday, October 12, 2016 12:04:34 AM PDT sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> This should make the code more robust if a shader tries to use inputs which
> aren't defined by the vertex element layout (which usually shouldn't happen).
> 
> No piglit change.
> ---
>  src/gallium/auxiliary/draw/draw_llvm.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Well, "robust", or "hiding application bugs"...this likely introduces a
small but non-zero cost for correctly written applications, and only
benefits broken ones...seems like a bad trade-off to me...

For shader temporaries, we made this a drirc option.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161011/fb44e9ed/attachment.sig>


More information about the mesa-dev mailing list