[Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

Nicolas Koch nioko1337 at gmail.com
Wed Oct 12 01:08:17 UTC 2016


It's been a few days. Is anybody willing to push this?

On Thu, Oct 6, 2016 at 11:25 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> On Thu, Oct 6, 2016 at 12:21 PM, Nicolas Koch <nioko1337 at gmail.com> wrote:
>> If pPhysicalDevices is too small for all physical devices,
>> the driver must return VK_INCOMPLETE.
>> Since only a single physical device is supported, this is only the case
>> when pPhysicalDeviceCount == 0 && pPhysicalDevices != NULL.
>> ---
>>  src/intel/vulkan/anv_device.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
>> index c7b9979..76cbb69 100644
>> --- a/src/intel/vulkan/anv_device.c
>> +++ b/src/intel/vulkan/anv_device.c
>> @@ -385,6 +385,8 @@ VkResult anv_EnumeratePhysicalDevices(
>>     } else if (*pPhysicalDeviceCount >= 1) {
>>        pPhysicalDevices[0] = anv_physical_device_to_handle(&instance->physicalDevice);
>>        *pPhysicalDeviceCount = 1;
>> +   } else if (*pPhysicalDeviceCount < instance->physicalDeviceCount) {
>> +      return VK_INCOMPLETE;
>>     } else {
>>        *pPhysicalDeviceCount = 0;
>>     }
>> --
>> 2.10.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the mesa-dev mailing list