[Mesa-dev] [PATCH 01/12] isl/gen6: correctly check msaa layout samples count

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Oct 11, 2016 at 10:26 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> From: Emil Velikov <emil.velikov at collabora.com>
>
> Samples == 1 is a valid value, so returning false is plain wrong.
> Seeming copy/paste typo introduced since day 1.
>
> Fixes: afdadec77f5 ("isl: Implement isl_surf_init() for gen4-gen9")
> Cc: Chad Versace <chadversary at chromium.org>
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: mesa-stable at lists.freedesktop.org
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/intel/isl/isl_gen6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl_gen6.c b/src/intel/isl/isl_gen6.c
> index b30998d..07c08f6 100644
> --- a/src/intel/isl/isl_gen6.c
> +++ b/src/intel/isl/isl_gen6.c
> @@ -35,7 +35,7 @@ gen6_choose_msaa_layout(const struct isl_device *dev,
>
>     if (info->samples == 1) {
>        *msaa_layout = ISL_MSAA_LAYOUT_NONE;
> -      return false;
> +      return true;
>     }
>
>     if (!isl_format_supports_multisampling(dev->info, info->format))
> --
> 2.10.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161011/e18cce0c/attachment.html>