[Mesa-dev] [PATCH v3 01/25] configure.ac: Don't search llvm-config if it's known

[Emil Velikov]

On 12 October 2016 at 00:02, Tobias Droste <tdroste at gmx.de> wrote:
> This way LLVM_CONFIG can bet set from an env variable if it's outside
> the $llvm_prefix.
>
> This is not a must, but it helps testing.
>
Indeed. Nicely done !

> Signed-off-by: Tobias Droste <tdroste at gmx.de>
> ---
>  configure.ac | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index b414edd..bdd46bc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2207,10 +2207,12 @@ if test "x$enable_gallium_llvm" = xauto; then
>      esac
>  fi
>  if test "x$enable_gallium_llvm" = xyes || test "x$HAVE_RADEON_VULKAN" = xyes; then
> -    if test -n "$llvm_prefix"; then
> -        AC_PATH_TOOL([LLVM_CONFIG], [llvm-config], [no], ["$llvm_prefix/bin"])
> -    else
> -        AC_PATH_TOOL([LLVM_CONFIG], [llvm-config], [no])
> +    if test -z "${LLVM_CONFIG}"; then
Nit: Please drop the {}.

With that
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil