[Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

Emil Velikov emil.l.velikov at gmail.com
Wed Oct 12 09:57:14 UTC 2016


On 12 October 2016 at 00:02, Tobias Droste <tdroste at gmx.de> wrote:
> Each driver has to expllicitly call llvm_add_default_components to
> add the shared components.
> This way we can fail the build if a component is not found and avoid
> the recursive solution from a previous version of the pach series.
>
s/pach/patch/

Does this mean that the "default" components are required only by the
gallivm module ? Please rename the function to reflect that.

Don't recall if swr driver is/was using any of it, but the nv30 path
of nouveau does use it, iirc. In the latter you want to call the
function if --enable-gallium-llvm is set. Alternatively keep
llvm_add_default_components within the "test enable_gallium_llvm !=
xno" block.

-Emil


More information about the mesa-dev mailing list