[Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

Tobias Droste tdroste at gmx.de
Wed Oct 12 18:04:58 UTC 2016


Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov:
> >  fi
> > 
> > +if test "x$enable_opencl" = xyes; then
> > +    llvm_check_version_for "3" "6" "0" "opencl"
> > +
> > +    LLVM_COMPONENTS="${LLVM_COMPONENTS} all-targets ipo linker
> > instrumentation" +    LLVM_COMPONENTS="${LLVM_COMPONENTS} irreader option
> > objcarcopts profiledata" +fi
> > +
> > +dnl Check for Clang internal headers
> > +if test "x$enable_opencl" = xyes; then
> 
> Nit: drop the second if test, yet preserve the comment ?
> Disclaimer: haven't looked if later patches depend on the split.

This is a "just move" patch, that's why I didn't change anything.
But this whole section will be changed later (Patch 11) so it actually doesn't 
matter.

I leave it as is but keep your reviewed-by, ok? :-)

> 
> With the above
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil


More information about the mesa-dev mailing list