[Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

[Tobias Droste]

Am Mittwoch, 12. Oktober 2016, 19:30:51 CEST schrieb Emil Velikov:
> >> 
> >> The function it quite "ugly" as-is and this patch changes things in a fun
> >> way.
> >> 
> >> Namely: before you'll get the minimum required version check
> >> regardless of host_cpu for everyone, while now you get the opposite -
> >> everyone is 'constrained' by the host_cpu check. Admittedly I've have
> >> not idea if llvmpipe is a thing on outside x86 land.
> >> 
> >> Checking the gallium_require_llvm users we want:
> >>  - swr -> bail out if host_cpu !x86/x86-64 or gallium-llvm toggle is
> >> 
> >> off || llvm version req. is not met
> >> 
> >>  - r300 -> on host_cpu eq. x86/x86-64, check the gallium-llvm toggle
> >> 
> >> (this is 'premature' optimisation which we might want to rework/drop
> >> in the long run)
> > 
> > Right now --enable-gallium-llvm will be set to no if it is "auto" on non
> > x86.
> > 
> > gallivm/llvm use the x86 target
> 
> I haven't look too closely at the llvm code but there's nothing in
> scons/automake which supports this, perhaps Jose can confirm.
> 
> Jose, does the gallium llvm code require the x86 target or can it work
> with other as well ? At least in theory.

I looked at this:

https://cgit.freedesktop.org/mesa/mesa/tree/configure.ac#n2204

if test "x$enable_gallium_llvm" = xauto; then
    case "$host_cpu" in
    i*86|x86_64|amd64) enable_gallium_llvm=yes;;
    esac
fi

That's why I thought it's only x86.

> 
> Thanks
> Emil