[Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

Edward O'Callaghan funfunctor at folklore1984.net
Thu Oct 13 03:15:15 UTC 2016


Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 10/13/2016 05:05 AM, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> At the moment (albeit unlikely) one could get link-time issues, since
> libdrm_amdgpu.so is before it's users in the link chain.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> As a nice bonus the diff vs the anv Makefile is quite small now ;-)
> ---
>  src/amd/vulkan/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
> index b6f3d00..e2f5c02 100644
> --- a/src/amd/vulkan/Makefile.am
> +++ b/src/amd/vulkan/Makefile.am
> @@ -58,7 +58,7 @@ VULKAN_SOURCES = \
>  	$(VULKAN_GENERATED_FILES) \
>  	$(VULKAN_FILES)
>  
> -VULKAN_LIB_DEPS = $(AMDGPU_LIBS)
> +VULKAN_LIB_DEPS =
>  
>  
>  if HAVE_PLATFORM_X11
> @@ -100,6 +100,7 @@ VULKAN_LIB_DEPS += \
>  	$(LLVM_LIBS) \
>  	$(LIBELF_LIBS) \
>  	$(PTHREAD_LIBS) \
> +	$(AMDGPU_LIBS) \
>  	$(LIBDRM_LIBS) \
>  	$(PTHREAD_LIBS) \
>  	$(DLOPEN_LIBS) \
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161013/89cbdcb5/attachment.sig>


More information about the mesa-dev mailing list