[Mesa-dev] [PATCH] egl/surfaceless: use correct index when accesing the visual

Eric Engestrom eric at engestrom.ch
Sat Oct 15 00:26:43 UTC 2016


On Fri, Oct 14, 2016 at 09:42:00PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> i is used for the driver_configs, while j is for the visuals.
> 
> Fixes: 4b8a55809eb ("egl/surfaceless: tweak surfaceless_add_configs_for_visuals()")
> Reported-by: Chad Versace <chadversary at chromium.org>
> Cc: Chad Versace <chadversary at chromium.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

Reviewed-by: Eric Engestrom <eric at engestrom.ch>

> ---
>  src/egl/drivers/dri2/platform_surfaceless.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/egl/drivers/dri2/platform_surfaceless.c b/src/egl/drivers/dri2/platform_surfaceless.c
> index 3fc1a68..f891d91 100644
> --- a/src/egl/drivers/dri2/platform_surfaceless.c
> +++ b/src/egl/drivers/dri2/platform_surfaceless.c
> @@ -198,7 +198,7 @@ surfaceless_add_configs_for_visuals(_EGLDriver *drv, _EGLDisplay *dpy)
>           struct dri2_egl_config *dri2_conf;
>  
>           dri2_conf = dri2_add_config(dpy, dri2_dpy->driver_configs[i],
> -               count + 1, EGL_PBUFFER_BIT, NULL, visuals[i].rgba_masks);
> +               count + 1, EGL_PBUFFER_BIT, NULL, visuals[j].rgba_masks);
>  
>           if (dri2_conf) {
>              count++;
> -- 
> 2.9.3


More information about the mesa-dev mailing list