[Mesa-dev] [PATCH 00/10] intel/genxml: Make more stuff booleans

Kenneth Graunke kenneth at whitecape.org
Sat Oct 15 10:31:07 UTC 2016


On Friday, October 14, 2016 11:11:11 PM PDT Jason Ekstrand wrote:
> This is a fairly trivial little cleanup that makes a bunch of 1-bit fields
> that used to have the "uint" type have the "bool" type instead.  Ideally, a
> field should have the "bool" type if and only if, given the name of the
> field and a true/false value, it's obvious what that value means.  I think
> this little series gets us most of the way there.  The only 1-bit fields
> left are either media things or things that don't have an obvious
> true/false meaning to me.
> 
> Jason Ekstrand (10):
>   intel/genxml: Make "Single Program Flow" a boolean
>   intel/genxml: Make "Vector Mask Enable" a boolean
>   intel/genxml: Make "Include Vertex Handles" and "Include Primitive ID"
>     booleans
>   intel/genxml: Make a couple of STREAMOUT fields booleans
>   intel/genxml: Make "Stencil Buffer Enable" a boolean
>   intel/genxml: Make "SO Buffer Enable" fields boolean
>   intel/genxml; Make "Tiled Surface" a boolean
>   intel/genxml; Make "Use Global GTT a boolean
>   intel/genxml: Make "Predication enable" a boolean
>   intel/genxml: Make some PIPE_CONTROL fields booleans

I'll admit to skimming a bit, but the series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

and thanks for dropping the SPF/VME abbreviations - making that
consistent makes it easier to share code across stages and generations.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161015/e925f015/attachment.sig>


More information about the mesa-dev mailing list