[Mesa-dev] [PATCH v4 00/18] configure.ac: Hopefully the last!

[Tobias Droste]

This series leaves out everything from the previous series that was 
to controversial, requires more discussions or could be done as a
follow up.

It just cleans up how LLVM version/target/component checks are used.
No version or other requirements were changed.

I reordered the patches a little bit and reduced the code movement
a lot.
There's only 1 line that is moved twice (call of the function
"llvm_set_environment_variables()"), but there's no way around this
(patch 12 and patch 14). The reason why is explained in patch 12.

After each patch I made sure that these drivers:
r300,r600,radeonsi,radv,llvmpipe
either build or fail to configure under these conditions:
a) LLVM installed and version >= version required 
    --> build
b) LLVM not installed 
    --> fail to configure
c) LLVM installed and version < version required 
    --> fail to configure
d) LLVM installed, version >= version required but missing target/component 
    --> fail to configure
e) "enable-gallium-llvm" needed but "disable-gallium-llvm" used
    --> fail to configure
    
I also made sure that i965 ("classic" dri driver) and softpipe build 
regardless of the LLVM version or if LLVM is installed.

@Emil:
I left "llvm_add_component()" to only take one component at the time.
This way the error message can state which component is actually 
missing. If you still want it changed to take multiple components
at once, this could be easily done.
Patches 5,6 and 7 could be one patch as they just move code around,
but the diff was really unreadable so I split it up.
I also kept the reviewed by tag for patch 1 and (now) patch 8, 
because they didn't change.

Tobias Droste (18):
  configure.ac: Don't search llvm-config if it's known
  configure.ac: Add helper function for targets/components
  configure.ac: Use new llvm_add_default_components
  configure.ac: Use new helper function for LLVM
  configure.ac: Move LLVM version check to the top
  configure.ac: Move LLVM functions to the top
  configure.ac: Move llvm-config searching outside the function
  configure.ac: Remove useless oCL LLVM check
  configure.ac: Use short names for r600 und r300
  configure.ac: Check gallium LLVM version in gallium_require_llvm
  configure.ac: Remove swr_llvm_check()
  configure.ac: Move llvm_set_environment_variables higher.
  configure.ac: Move oCL LLVM checks to the oCL section
  configure.ac: Move LLVM ac_subst closer to usage
  configure.ac: Move radv check to the Vulkan section
  configure.ac: Reorder arguments in radeon_llvm_check
  configure.ac: Only add default LLVM components if needed
  configure.ac: Add required LLVM versions to the top

 configure.ac | 450 ++++++++++++++++++++++++++++++++++-------------------------
 1 file changed, 260 insertions(+), 190 deletions(-)

-- 
2.10.1