[Mesa-dev] [PATCH 20/22] anv: move to using shared wsi code

[Emil Velikov]

Hi Dave,

Thanks for doing this. It'll be great to get an Ack from the Intel
devs, on the idea.

Afaics with 22/22 in place you can drop the vk_alloc2/vk_free2
functions since they are no longer used.

Just an extra (small) suggestion below:

On 17 October 2016 at 05:24, Dave Airlie <airlied at gmail.com> wrote:

>  delete mode 100644 src/intel/vulkan/wsi_common.h
>  delete mode 100644 src/intel/vulkan/wsi_common_wayland.c
>  delete mode 100644 src/intel/vulkan/wsi_common_wayland.h
>  delete mode 100644 src/intel/vulkan/wsi_common_x11.c
>  delete mode 100644 src/intel/vulkan/wsi_common_x11.h
>  create mode 100644 src/vulkan/wsi/Makefile.am
>  create mode 100644 src/vulkan/wsi/Makefile.sources
>  create mode 100644 src/vulkan/wsi/wsi_common.h
>  create mode 100644 src/vulkan/wsi/wsi_common_wayland.c
>  create mode 100644 src/vulkan/wsi/wsi_common_wayland.h
>  create mode 100644 src/vulkan/wsi/wsi_common_x11.c
>  create mode 100644 src/vulkan/wsi/wsi_common_x11.h
>
Can you use git format-patch -M (or $git config --global diff.renames
true) so that the diff is friendlier.


> diff --git a/configure.ac b/configure.ac
> index 37cc306..688459b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2854,7 +2854,8 @@ AC_CONFIG_FILES([Makefile
>                 src/mesa/main/tests/Makefile
>                 src/util/Makefile
>                 src/util/tests/hash_table/Makefile
> -               src/vulkan/Makefile])
> +               src/vulkan/Makefile
> +               src/vulkan/wsi/Makefile])
>
Just fold the new Makefile into the existing one ? In should be as
simple as adding wsi/ prefix to files.
Alternatively we can do that as a follow-up.

Emil