[Mesa-dev] [PATCH 21/22] wsi: swap srgb/unorm around.

Jason Ekstrand jason at jlekstrand.net
Tue Oct 18 20:33:50 UTC 2016


NAKish... I specifically put them in that order to *cause* talos to break.
If we're going to support both UNORM and sRGB, then applications need to
look at the formats they're getting and pick one intelligently rather than
just using the first thing they find (which Talos does) especially if that
app does their own gamma curvs.  Apps that just grab the first thing they
find probably "want" sRGB encoding done for them.  I've talked to the guys
at croteam and there is a Talos update in the pipe that fixes this.

On Sun, Oct 16, 2016 at 9:24 PM, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> This prevents a Talos regression before radv
> starts using shared WSI.
> ---
>  src/vulkan/wsi/wsi_common_x11.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_
> x11.c
> index b5832c6..241ef42 100644
> --- a/src/vulkan/wsi/wsi_common_x11.c
> +++ b/src/vulkan/wsi/wsi_common_x11.c
> @@ -135,8 +135,8 @@ wsi_x11_get_connection(struct wsi_device *wsi_dev,
>  }
>
>  static const VkSurfaceFormatKHR formats[] = {
> -   { .format = VK_FORMAT_B8G8R8A8_SRGB, },
>     { .format = VK_FORMAT_B8G8R8A8_UNORM, },
> +   { .format = VK_FORMAT_B8G8R8A8_SRGB, },
>  };
>
>  static const VkPresentModeKHR present_modes[] = {
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161018/baf0dda5/attachment.html>


More information about the mesa-dev mailing list