[Mesa-dev] [PATCH 08/11] anv: move to using vk_alloc helpers.

[Dave Airlie]

On 19 October 2016 at 03:18, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Dave,
>
> On 17 October 2016 at 03:07, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This moves all the alloc/free in anv to the generic helpers.
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  src/intel/vulkan/anv_batch_chain.c    | 40 +++++++++++++++---------------
>>  src/intel/vulkan/anv_cmd_buffer.c     | 22 ++++++++---------
>>  src/intel/vulkan/anv_descriptor_set.c | 12 ++++-----
>>  src/intel/vulkan/anv_device.c         | 26 ++++++++++----------
>>  src/intel/vulkan/anv_image.c          | 14 +++++------
>>  src/intel/vulkan/anv_intel.c          |  4 +--
>>  src/intel/vulkan/anv_pass.c           | 10 ++++----
>>  src/intel/vulkan/anv_pipeline.c       |  6 ++---
>>  src/intel/vulkan/anv_pipeline_cache.c |  8 +++---
>>  src/intel/vulkan/anv_private.h        | 46 +----------------------------------
>>  src/intel/vulkan/anv_query.c          |  6 ++---
>>  src/intel/vulkan/anv_wsi.c            |  2 +-
>>  src/intel/vulkan/anv_wsi_wayland.c    | 16 ++++++------
>>  src/intel/vulkan/anv_wsi_x11.c        | 22 ++++++++---------
>>  src/intel/vulkan/gen7_pipeline.c      |  4 +--
>>  src/intel/vulkan/gen8_pipeline.c      |  4 +--
>>  src/intel/vulkan/genX_pipeline.c      |  6 ++---
>>  src/intel/vulkan/genX_state.c         |  2 +-
>>  18 files changed, 103 insertions(+), 147 deletions(-)
>>
> Wondering we one shouldn't include the new header only where needed ?
> Quick grep shows 33 files which include anv_private.h of which (as per
> above) ~half only need vk_alloc.h.

Don't really see the benefit, splitting anv_private.h would be a
bigger job I would think.

Dave.