[Mesa-dev] [PATCH 2/2] mesa: add missing formats to driGLFormatToImageFormat

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 20 16:37:15 UTC 2016


On 20 October 2016 at 10:02, Tapani Pälli <tapani.palli at intel.com> wrote:
> Fixes following dEQP tests:
>
>    dEQP-EGL.functional.image.api.create_image_gles2_tex2d_luminance
>    dEQP-EGL.functional.image.api.create_image_gles2_tex2d_luminance_alpha
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98328
> ---
>  src/mesa/drivers/dri/common/dri_util.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
> index 79cb050..3b81799 100644
> --- a/src/mesa/drivers/dri/common/dri_util.c
> +++ b/src/mesa/drivers/dri/common/dri_util.c
> @@ -842,8 +842,10 @@ driGLFormatToImageFormat(mesa_format format)
>        return __DRI_IMAGE_FORMAT_ABGR8888;
>     case MESA_FORMAT_R8G8B8X8_UNORM:
>        return __DRI_IMAGE_FORMAT_XBGR8888;
> +   case MESA_FORMAT_L_UNORM8:
>     case MESA_FORMAT_R_UNORM8:
>        return __DRI_IMAGE_FORMAT_R8;
> +   case MESA_FORMAT_L8A8_UNORM:
>     case MESA_FORMAT_R8G8_UNORM:
The patch looks OK (even though the inverse API
driImageFormatToGLFormat isn't updated), but I'm quite weary on format
changes.
Please check that this doesn't cause issues with cts/piglit/deqp and
that weston (and/or other wayland compositors) work fine.

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Emil


More information about the mesa-dev mailing list