[Mesa-dev] [PATCH 31/42] compiler: don't bother setting INTERP_MODE_NONE to 0

[Timothy Arceri]

On Thu, 2016-10-20 at 20:03 -0700, Jason Ekstrand wrote:
> I'm not so sure we can sure about this one.  I think we also somewhat
> rely on being able to memset ir_variable and nir_variable to zero as
> well.

Sure I can change this patch to just update the comment. 

gl_fragment_program -> ir_variable

> 
> On Wed, Oct 19, 2016 at 4:09 PM, Timothy Arceri <timothy.arceri at colla
> bora.com> wrote:
> > Now that the InterpQualifier array has been removed we don't need
> > to
> > bother with this.
> > ---
> >  src/compiler/shader_enums.h | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/src/compiler/shader_enums.h
> > b/src/compiler/shader_enums.h
> > index b6e048e..aa97691 100644
> > --- a/src/compiler/shader_enums.h
> > +++ b/src/compiler/shader_enums.h
> > @@ -489,13 +489,10 @@ const char
> > *gl_system_value_name(gl_system_value sysval);
> >  /**
> >   * The possible interpolation qualifiers that can be applied to a
> > fragment
> >   * shader input in GLSL.
> > - *
> > - * Note: INTERP_MODE_NONE must be 0 so that memsetting the
> > - * gl_fragment_program data structure to 0 causes the default
> > behavior.
> >   */
> >  enum glsl_interp_mode
> >  {
> > -   INTERP_MODE_NONE = 0,
> > +   INTERP_MODE_NONE,
> >     INTERP_MODE_SMOOTH,
> >     INTERP_MODE_FLAT,
> >     INTERP_MODE_NOPERSPECTIVE,
> > --
> > 2.7.4
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev