[Mesa-dev] [Bug 98299] Compute shaders generate stupid divides

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 24 09:22:23 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=98299

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ian Romanick <idr at freedesktop.org> ---
Fixed by:

commit 4d35683d91e3d61bf14b76d801bf6ae17237e162
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed Oct 19 08:53:10 2016 -0700

    nir: Optimize integer division and modulus with 1

    The previous power-of-two rules didn't catch idiv (because i965 doesn't
    set lower_idiv) and imod cases.  The udiv and umod cases should have
    been caught, but I included them for orthogonality.

    This fixes silly code observed from compute shaders with local_size_[xy]
    = 1.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98299
    Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161024/0dc0b616/attachment.html>


More information about the mesa-dev mailing list