[Mesa-dev] [PATCH] mapi: automake: set VISIBILITY_CFLAGS for shared glapi

[Eric Engestrom]

On Saturday, 2016-10-22 18:19:53 +1100, Jonathan Gray wrote:
> shared glapi was previously built without setting CFLAGS for
> AM_CFLAGS and VISIBILITY_CFLAGS.
> 
> This resulted in symbols being exported that shouldn't be.
> 
> The x86 and sparc assembly versions of the dispatch table partially
> mitigated this by using .hidden.  Otherwise shared_dispatch_stub_*
> were being exported.
> 
> Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
> Cc: "11.2 12.0 13.0" <mesa-stable at lists.freedesktop.org>

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  src/mapi/Makefile.am | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am
> index 5a58ca2..f35cedc 100644
> --- a/src/mapi/Makefile.am
> +++ b/src/mapi/Makefile.am
> @@ -64,6 +64,9 @@ BUILT_SOURCES += shared-glapi/glapi_mapi_tmp.h
>  
>  lib_LTLIBRARIES += shared-glapi/libglapi.la
>  shared_glapi_libglapi_la_SOURCES = $(MAPI_GLAPI_FILES) shared-glapi/glapi_mapi_tmp.h
> +shared_glapi_libglapi_la_CFLAGS = \
> +	$(AM_CFLAGS) \
> +	$(VISIBILITY_CFLAGS)
>  shared_glapi_libglapi_la_CPPFLAGS = \
>  	$(AM_CPPFLAGS) \
>  	-DMAPI_MODE_GLAPI \
> -- 
> 2.9.3
>