[Mesa-dev] [PATCH] egl/android: implement minimal swap_buffers_with_damage

[Rob Herring]

On Mon, Oct 24, 2016 at 3:34 AM, Eric Engestrom
<eric.engestrom at imgtec.com> wrote:
> On Friday, 2016-10-21 16:07:07 -0500, Rob Herring wrote:
>> Since commit 0a606a400fe3 ("egl: add eglSwapBuffersWithDamageKHR"),
>> Android has been broken because the function eglSwapBuffersWithDamageKHR
>> is provided regardless of the extension being present. Also, the Android
>> meta-EGL always advertises the extension regardless of the underlying
>> EGL implementation.
>
> Where is that? I'd like to have a look when I find some time.

frameworks/native/opengl/libs/EGL/eglApi.cpp:86

>
>> As there doesn't seem to be a simple way
>> conditionally make the EGL function ptr NULL, just implement a brain
>> dead version for Android EGL.
>
> Ignoring the rectangles and doing a full swap regardless is indeed
> allowed by the spec, so this is:
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

Thanks.

Rob