[Mesa-dev] [PATCH 00/24] RadeonSI: Massive radeon_surf winsys interface cleanup and more

[Marek Olšák]

I think there is a subtle but important SI fix in patch 20 that didn't
occur to me:
[PATCH 20/24] gallium/radeon: don't force the same tiling parameters for FMASK
.. which makes FMASK parameters completely independent of the color surface.

It fixes an incorrect value in the FMASK_BANK_HEIGHT register field,
because it can't be the same as the color bank height, because FMASK
has a different bpp in 99% cases and thus a different macro tile mode.
Also, other macro tile parameters were wrong too, but I don't know if
it had any effect on surface_init, and the hardware derived them from
bpp and the macro tile array anyway.

Marek



On Tue, Oct 25, 2016 at 12:33 AM, Marek Olšák <maraeo at gmail.com> wrote:
> Hi,
>
> Most of this series cleans up the radeon_surf-based winsys interface,
> and texture, fmask, and metadata (cmask, htile) allocation, and also
> other code working with textures.
>
> The series starts with EVENT_WRITE_EOP cleanups and ends with buffer_create
> cleanups.
>
> Please review.
>
> Marek